Improvements to the forum
-
@lia chrome
not in sources either
-
Made it much smaller, does that work better or shall I remove it till I find a better way to have it display?
-
-
@lia said in Improvements to the forum:
Made it much smaller, does that work better or shall I remove it till I find a better way to have it display?
oh i know why! its not on ur 'home' page but rather ../categories
yes nice banner lol.
-
@horseplay Sorry about that, it must have rendered fine for me because I had it cached from viewing it a few times in testing. Was way too HD for it's needs.
@NotSure I have it showing on categories but also when landing on owforum.co.uk.
Glad it's looks nice :)
-
@lia said in Improvements to the forum:
I have it showing on categories but also when landing on owforum.co.uk.
umm...
-
@notsure Oh that's the recent tab, is that home for you?
-
@lia said in Improvements to the forum:
@notsure Oh that's the recent tab, is that home for you?
debugged!
-
@lia said in Improvements to the forum:
Can we get some hype for the new homepage banner ;)
LOVE IT! great work.
-
YOUTUBE EMBEDS WORK NOW :D :D :D :D
Simply copy the YT URL into the post and it will embed the video in it's place.
Videos will also play in the embed rather than redirect off platform so you don't need to faff around with tabs.Example below :)
-
@lia example test
" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
<iframe width="560" height="315" src=" -
@notsure said in Improvements to the forum:
@lia example test
example test test
"
src="just need the link it seems.
-
@notsure Don't need any of the embed code, just the link :)
-
@lia said in Improvements to the forum:
@notsure Don't need any of the embed code, just the link :)
-
Plugin uses iframes for embedding which is a bit taxing once a handful are present on the page. So much so that the "Share your float playlist <3" thread is extremely slow to load.
Timestamping also seems to get ignored so will see if I can get that to be retained.
The embed script is configurable so I might see if I can have it render differently. Will test when it's quiet on the platform. Shouldn't require a reboot but I tend to avoid live changes like that anyway.
-
@lia said in Improvements to the forum:
So much so that the "Share your float playlist <3" thread is extremely slow to load.
lol
-
@notsure Don't worry about doing anything to it, I'll find a way to make it nice. Wouldn't want to undo all that effort you put in :)
-
Added lazy loading into the iframes so they shouldn't all try to load the moment the page is touched.
@lia said in Improvements to the forum:
Timestamping also seems to get ignored so will see if I can get that to be retained.
Unable to modify the regex to understand the extra length of timestamp code or playlists at the end. Mostly since it's written in a way I can't parse, below is that is there currently if anyone's interested.
Regex
(?:<a.*?)?(?:https?:\/\/)?(?:www\.)?(?:youtube\.com\/(?!user|channel)\S*(?:(?:\/e(?:mbed))?\/|watch\?(?:\S*?&?v\=))|youtu\.be\/)([a-zA-Z0-9_-]{6,11})(?:.*?\/a>)?
Replace
<div class='embed-wrapper'><div class='embed-container'><iframe src='https://www.youtube.com/embed/$1' loading='lazy' class='lazyload' frameborder='0' allowfullscreen></iframe></div></div>
Tried modifying what appears to be the bit that checks the bit after "V=" but it seems to brick the plugin when I add bits.
([a-zA-Z0-9_-]{6,11})
Wanted to add "?" and "=" but those stop it working even if I try to escape the characters. Modifying the character length "6,11" doesn't break it but also doesn't do much if I can't get the extra chunk of URL to be read.
.
Stuck with iframes since they're the only good way to embed a video after a bit of research. If this plugin does make things a pain or slows certain threads down let me know and I'll remove it.
-
-
@notsure Oh god no wonder I was struggling regex is a nightmare!
Thought I had it but adding an extra match for the timestamps causes the output to duplicate D:(?:<a.*?)?(?:https?:\/\/)?(?:www\.)?(?:youtube\.com\/(?!user|channel)\S*(?:(?:\/e(?:mbed))?\/|watch\?(?:\S*?&?v\=))|youtu\.be\/)([a-zA-Z0-9_?&=-]{6,11})|(?:\?t=)([a-zA-Z0-9_?&=-]{1,4})(?:.*?\/a>)?
Going to spend a bit more time looking at that, thanks for that tool though, super useful!